Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): Notebooks 2.0 // Backend // List namespaces #124

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Nov 12, 2024

closes #53

Namespaces listing will be used to create a workspace and on the test app to create a namespace selector.

In this PR:

  • handler and repository to fetch namespaces.
  • rename the workspacekinds_handler test to align with the main file name.
Screenshot 2024-11-12 at 7 30 00 AM
  • The screenshot lists all namespaces, but we should restrict to namespaces that the user can access in a fup PR.

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper changed the title feat(ws): Notebooks 2.0 // Backend // List namespaces #53 feat(ws): Notebooks 2.0 // Backend // List namespaces Nov 28, 2024
@thesuperzapper
Copy link
Member

I have updated the GHA workflows to run tests/linting on backend PRs now f986d27

But otherwise, looks fine to merge for now.

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2b747ac into kubeflow:notebooks-v2 Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants