Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inputs with multiple arguments #1933

Closed
Ark-kun opened this issue Aug 22, 2019 · 10 comments
Closed

Support inputs with multiple arguments #1933

Ark-kun opened this issue Aug 22, 2019 · 10 comments

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 22, 2019

Need to support variadic inputs in ComponentSpec, Lightweight components, load_component etc.

In command-line we can pass multiple inputs as repeated command-line parameters: --a 1 --a 2.
In TaskSpec we can make argument a list: arguments: {a: [1, 2]}.
In inputSpec we could add repeated: true or allowMultiple: true property.
In ContainerImplementation we could specify the command args as follows: {map: {source: {inputValue: RepInput}, selector: [--a, {item}] }}

Related: #1901

@areshytko
Copy link

is this feature planned to be implemented in the upcoming releases? It would be great to have it in KFP

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 10, 2020

is this feature planned to be implemented in the upcoming releases? It would be great to have it in KFP

At this moment there we have no bandwidth for implementing this feature. It needs many places to change.

What is the scenario where you might want this feature?

@areshytko
Copy link

The use case is the following: we have K-fold a cross-validation task somewhere in the middle of our pipelines, and the number of fold is the parameter to the pipeline. The desire is to distribute computation of each fold to a separate task and run them in parallel since this is a time-consuming operation. Basically this requires the following:

image
Task C now requires a variable number of input parameters.

Can we offer our help and contribute to the implementation of this feature under this ticket?

@ca-scribner
Copy link
Contributor

Does anyone have a pattern to make something like this work? The only hacks I've thought of would be maybe something like a simple shell call that takes the values from TaskB-1...TaskB-N and concatenates them to a single string (json or just space deliminated) or maybe to lines in a file, then TaskC takes that concatenation as input and knows how to parse it

Other ideas might be that TaskB-* concatenate their results somewhere central and TaskC grabs from there. So maybe TaskB-* write results to the same location, and TaskC grep's from there?

@stale
Copy link

stale bot commented Sep 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 15, 2020
@stale
Copy link

stale bot commented Sep 22, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Sep 22, 2020
@Ark-kun Ark-kun reopened this Sep 22, 2020
@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 22, 2020
@Ark-kun Ark-kun added lifecycle/frozen lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Sep 22, 2020
@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 22, 2020
@BenoitLeguay
Copy link

Any news on this feature ? :)
Thank you !

@SaschaHeyer
Copy link

This feature request is closely related to #3412
Are there any updates on that this is a request I have seen already multiple times.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* Add feature to use grpc

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add custom grpc transformer example

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add gRPC transformer example

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* add cifar image input file

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add triton grpc transformer e2e test

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add protocol arg for grpc

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Convert to list

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix python test action

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@rimolive
Copy link
Member

rimolive commented Apr 5, 2024

Closing this issue. No activity for more than a year.

/close

Copy link

@rimolive: Closing this issue.

In response to this:

Closing this issue. No activity for more than a year.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Closed
Development

No branches or pull requests

6 participants