Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Pipelines backward compatibility when Kubeflow switches to workload identity #1962

Closed
jlewi opened this issue Aug 27, 2019 · 3 comments
Assignees
Labels
area/pipelines platform/gcp priority/p2 status/triaged Whether the issue has been explicitly triaged

Comments

@jlewi
Copy link
Contributor

jlewi commented Aug 27, 2019

In 0.7 Kubeflow on GCP would like to switch to using workload identity by default #1691 .
https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#enable_workload_identity_on_a_new_cluster

This means that applications should be deployed with an appropriate Kubernetes Service Account Mapped to a Google Service Account in order to get GCP credentials.

The purpose of this bug is to ascertain whether for backwards compatibility we should continue to provision service account keys in the kubeflow namespace to support existing pipelines which are using

add_gcp_secret("user-gcp-sa")

@IronPan WDYT?

@jessiezcc
Copy link
Contributor

@james-jwu, can you pls assess?

@jessiezcc jessiezcc added the status/triaged Whether the issue has been explicitly triaged label Sep 20, 2019
@jlewi
Copy link
Contributor Author

jlewi commented Nov 2, 2019

With 0.7 we have continued to provision user-gcp-sa secrets but we will stop doing that in subsequent releases so pipelines will need to update to work with workload identity.

@jlewi
Copy link
Contributor Author

jlewi commented Nov 2, 2019

I think we can close this issue and use #1691 to track migrating pipelines to workload identity and removing the secrets.

@jlewi jlewi closed this as completed Nov 2, 2019
@rmgogogo rmgogogo self-assigned this Nov 16, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
Signed-off-by: Hao Xin <haoxinst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pipelines platform/gcp priority/p2 status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Development

No branches or pull requests

5 participants