Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK/Compiler] Sample was broken by new large data passing mechanism #2307

Closed
numerology opened this issue Oct 4, 2019 · 2 comments
Closed

Comments

@numerology
Copy link

This Github issue summary sample seems to be broken by our new changes.

Reported by Amy

Traceback (most recent call last):
  File "gh_summ1gpu.py", line 114, in <module>
    compiler.Compiler().compile(gh_summ, __file__ + '.tar.gz')
  File "/Users/amyu/miniconda3/envs/mlpipeline2/lib/python3.6/site-packages/kfp/compiler/compiler.py", line 836, in compile
    workflow = self._compile(pipeline_func)
  File "/Users/amyu/miniconda3/envs/mlpipeline2/lib/python3.6/site-packages/kfp/compiler/compiler.py", line 822, in _compile
    return self.create_workflow(pipeline_func=pipeline_func)
  File "/Users/amyu/miniconda3/envs/mlpipeline2/lib/python3.6/site-packages/kfp/compiler/compiler.py", line 813, in create_workflow
    workflow = fix_big_data_passing(workflow)
  File "/Users/amyu/miniconda3/envs/mlpipeline2/lib/python3.6/site-packages/kfp/compiler/_data_passing_rewriter.py", line 146, in fix_big_data_passing
    assert argument_placeholder_parts[2] == 'outputs'
AssertionError

@Ark-kun can you take a look when you have time?

@numerology numerology changed the title [SDK/Compiler] Sample break by new large data passing mechanism [SDK/Compiler] Sample was broken by new large data passing mechanism Oct 4, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

Duplicate of #2295
There is a fix PR pending, but there is a license complication.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 9, 2019

Fixed by #2297

@Ark-kun Ark-kun closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants