Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Compiler - Fix bugs in the data passing rewriter #2297

Merged
merged 3 commits into from
Oct 8, 2019

Conversation

deepio-oc
Copy link
Contributor

@deepio-oc deepio-oc commented Oct 3, 2019

fix for #2295

argument_placeholder_parts seems to have been copied/pasted from the code above. parts seems to be the more suitable here.


This change is Reviewable

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @deepio-oc. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun Ark-kun changed the title fix for #2295 SDK - Compiler - Fix bug in the data passing rewriter Oct 4, 2019
@Ark-kun Ark-kun changed the title SDK - Compiler - Fix bug in the data passing rewriter SDK - Compiler - Fix bugs in the data passing rewriter Oct 4, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

Thank you a lot @deepio-oc .
Can you please sign the CLA? I'd really like to merge and release this fix today or tomorrow.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepio-oc
Copy link
Contributor Author

deepio-oc commented Oct 4, 2019

Thank you a lot @deepio-oc .
Can you please sign the CLA? I'd really like to merge and release this fix today or tomorrow.

My organization (One Convergence) has already signed CLA. I would like them to be credited for the fix.

@deepio-oc deepio-oc closed this Oct 4, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

My organization (One Convergence) has already signed CLA.

Are you using the correct e-mail in your commits?
Can you try checking the links the CLA bot has posted: #2297 (comment)

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

Thank you a lot @deepio-oc .
Can you please sign the CLA? I'd really like to merge and release this fix today or tomorrow.

My organization (One Convergence) has already signed CLA. I would like them to be credited for the fix.

We list all contributions with their respective contributors in our Changelog.

@Ark-kun Ark-kun reopened this Oct 4, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

/cc @deepio-oc Can you please fix the CLA so that your company can be credited in the Changelog?

Update: The CLA was signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants