Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Migrate to create-react-app and typescript-eslint #2432

Closed
Bobgy opened this issue Oct 18, 2019 · 4 comments · Fixed by #3156
Closed

[Frontend] Migrate to create-react-app and typescript-eslint #2432

Bobgy opened this issue Oct 18, 2019 · 4 comments · Fixed by #3156
Assignees
Labels
area/engprod area/frontend priority/p1 status/triaged Whether the issue has been explicitly triaged

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Oct 18, 2019

We are using deprecated library: https://github.com/wmonk/create-react-app-typescript with 2 high vulnerabilities, 3 moderate and 81 low.
Also tslint will soon be deprecated: palantir/tslint#4100 (comment).

Also, we have some developer experience problems with create-react-app-typescript:

  • the dev server watch mode randomly fails (reporting a module is not found) to build when there are code changes, this greatly interrupts usual dev workflow.

Migrating back to create-react-app allows us to use eslint. So both work needs to be done together. Putting these here as a tracker issue.

Reference:
There was an attempt doing this: #1208, but I don't know what was the blocker.

/area frontend
/priority p1

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 26, 2019

To add to that, new create-react-app comes with latest jest. I'd like to use some new features e.g. inline snapshots: facebook/create-react-app#5089

@Bobgy Bobgy added status/triaged Whether the issue has been explicitly triaged priority/p1 and removed area/front-end priority/p2 labels Feb 19, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 19, 2020

Bump priority because I think this help us use new best practices

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 23, 2020

This also blocks #3154.

I'll try to do this in a sooner time frame.

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 24, 2020

I found some breaking changes in jest snapshots, sending a separate PR to prepare those changes first.
#3159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engprod area/frontend priority/p1 status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants