Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial attempt to migrate from react-scripts-ts to react-scripts #1208

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Apr 23, 2019

WIP because it needs testing, manual and not


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rileyjbauer

If they are not already assigned, you can assign the PR to them by writing /assign @rileyjbauer in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented May 3, 2019

Testing
/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented May 3, 2019

/lgtm cancel

@k8s-ci-robot
Copy link
Contributor

@rileyjbauer: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test d9e9a6f link /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-sample-test d9e9a6f link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun Ark-kun assigned rileyjbauer and unassigned Ark-kun Jul 26, 2019
@Bobgy
Copy link
Contributor

Bobgy commented Oct 15, 2019

@Ark-kun do you know what happened to this? what was the blocker? I think it's something we'd like to do sooner or later.

@Bobgy
Copy link
Contributor

Bobgy commented Feb 24, 2020

/close
Superseded by #3156

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closed this PR.

In response to this:

/close
Superseded by #3156

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…ubeflow#1208)

* Update Outlier and Drift example for latest knative and cloudevents

* Add knative 0.18 as minimum version for drift and outlier notebooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants