Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline GCP sample components need to switch to default gcp ops #406

Closed
IronPan opened this issue Nov 28, 2018 · 2 comments
Closed

Pipeline GCP sample components need to switch to default gcp ops #406

IronPan opened this issue Nov 28, 2018 · 2 comments
Assignees
@IronPan
Labels
area/samples kind/feature priority/p2

Comments

@IronPan
Copy link
Member

IronPan commented Nov 28, 2018

Using default gcp ops will ensure those GCP samples still works
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/_default_gcp_op.py
@IronPan IronPan self-assigned this Nov 28, 2018
@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

@IronPan, can you provide more details? I do not understand this issue really well.

@IronPan
Copy link
Member Author

IronPan commented Mar 27, 2019

the gcp samples now mount gcp credentials so this is done.

@IronPan IronPan closed this as completed Mar 27, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@ariefrahmansyah @k8s-ci-robot
Refactor ExplainerSpec for better validation (kubeflow#406)
0d9c115 
* Refactor explainer for better ExplainerSpec validation

* Log error on getExplainer and getPredictor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IronPan IronPan

Labels
area/samples kind/feature priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IronPan @vicaire