Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare page perf optimizations #597

Closed
yebrahim opened this issue Dec 27, 2018 · 0 comments · Fixed by #598
Closed

Compare page perf optimizations #597

yebrahim opened this issue Dec 27, 2018 · 0 comments · Fixed by #598

Comments

@yebrahim
Copy link
Contributor

The page is slow mainly because of ROC plots and confusion matrices, which are inlined and not pure. This is a flamegraph of renders when collapsing/uncollapsing sections, see how ROC curve gets re-rendered:
image

And this is the code profiling on clicking the buttons, all taken up by React rendering:
image

I think if we move the plot containers to be pure components it'll fix this.

/area front-end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants