Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Question issue template #10557

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

rimolive
Copy link
Member

Description of your changes:
Fixes #4688

Add a template for users to ask questions

Checklist:

@chensun
Copy link
Member

chensun commented Mar 14, 2024

/hold

We were considering enabling GitHub Discussions for questions and general discussions.
Any comments/thoughts?

@HumairAK
Copy link
Contributor

I don't think GH issues should be for q/a.

Wouldn't having an issue template for a question only give the impression that we welcome q/a style gh issues?

I agree with sending such questions to GH discussions. Don't know too much about gh discussions, but it seems like for this we would want a category form: https://docs.github.com/en/discussions/managing-discussions-for-your-community/creating-discussion-category-forms instead of an issue template

@rimolive
Copy link
Member Author

cc @Tomcli

Looking for your thoughts too

@Tomcli
Copy link
Member

Tomcli commented Mar 14, 2024

In the new projects we created, we use GitHub discussions because it works like a forum where you can upvote the important discussion. This also help reduce the number of issues we have.

Before GitHub discussions, the only way users can ask question is through issues and slack, so you still see some old GitHub repo is doing that way. I agree we should use GitHub discussions instead as many community such as KServe, Argo already using it.

@gregsheremeta
Copy link
Contributor

not personally familiar with Discussions, but it seems like it will do the trick.

is it easy to enable?

@rimolive
Copy link
Member Author

@gregsheremeta Easy peasy! Just check this option in repo settings.

Screenshot from 2024-03-15 10-42-00

From GH Discussions, you can even use categories for discussions, and create polls.

Screenshot from 2024-03-15 10-42-59

@StefanoFioravanzo
Copy link
Member

I love the idea of moving Q/A and generic discussion to GH Discussions. That will help in reducing the number of issues and keep them higher quality

@StefanoFioravanzo
Copy link
Member

If we go with GH discussions, let's see if we can direct users to that when they try opening a new issue. See how they do it in JAX https://github.com/google/jax/issues/new/choose

@rimolive
Copy link
Member Author

rimolive commented Mar 24, 2024

@chensun Can you enable the discussions tab? I'll change the issues template to guide the community to that tab when enabled, following @StefanoFioravanzo suggestion.

EDIT: I went ahead and added the changes. When Discussions tab is enabled, we can merge this PR.

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
@chensun
Copy link
Member

chensun commented Mar 26, 2024

@chensun Can you enable the discussions tab?

Done.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rimolive I will leave it to you to unhold and merge.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rimolive
Copy link
Member Author

/unhold

@google-oss-prow google-oss-prow bot merged commit 06af0dc into kubeflow:master Mar 26, 2024
3 checks passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Community] GitHub issue templates for feature request and question
6 participants