Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursion bug fix #1061

Merged
merged 11 commits into from
Apr 2, 2019
Merged

Recursion bug fix #1061

merged 11 commits into from
Apr 2, 2019
+561 −117

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Mar 29, 2019 •
edited
Loading

Remove the graph component output
Add support for explicit dependency in dsl for both graph component and container_op
Support while loops

This change is Reviewable

@gaoning777
Copy link
Contributor Author

There is still a small bug for while-loop that I will address in a bit

@hongye-sun hongye-sun self-assigned this Mar 29, 2019
@gaoning777
Copy link
Contributor Author

bug fixed and unit tests added for while loops.

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

2 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

hongye-sun
hongye-sun reviewed Mar 30, 2019
View reviewed changes
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Unblock the loop support. It's actually really hard for me to understand the full logic in the compiler. There are lots of specialized code branches. We should have a big refactoring on the compiler after the Next release.

@gaoning777
Copy link
Contributor Author

SGTM. We do need some code refactoring for the DSL compiler after the NEXT.

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

3 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 30, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 2, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 2, 2019
@hongye-sun
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1a04e86 into kubeflow:master Apr 2, 2019
@gaoning777 gaoning777 deleted the recursion-bug-fix branch April 2, 2019 16:50
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
feat(sdk): add custom task param support in command spec (kubeflow#1061)
d0a0706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@hongye-sun hongye-sun

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @Ark-kun @hongye-sun @k8s-ci-robot