Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Kubeflow sample test #1096

Merged
merged 2 commits into from
Apr 6, 2019
Merged

Fixed Kubeflow sample test #1096

merged 2 commits into from
Apr 6, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 6, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun Ark-kun requested review from gaoning777 and hongye-sun April 6, 2019 02:49
@k8s-ci-robot k8s-ci-robot requested review from vicaire April 6, 2019 02:49
gaoning777
gaoning777 reviewed Apr 6, 2019
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when did we change it?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 6, 2019 •
edited
Loading

when did we change it?

When I switched the Kubeflow sample to use components a couple of days ago.
Kubeflow had "confusionmatrix" and XGBoost had "confusion-matrix" as the step name. When we started using the same component for both, the kubeflow sample test stopped working, because it searched for "confusionmatrix".

I verified that the whole sample completed successfully in a notebook, but I did not know that the sample test was sensitive to the step names.

@gaoning777
Copy link
Contributor

gaoning777 commented Apr 6, 2019 •
edited
Loading

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 6, 2019

/test kubeflow-pipeline-sample-test

@Ark-kun
Fixed the artifact-finding logic in get_artifact_in_minio.
6c9511b 
It was just taking the first artifact before.
Now it properly searches the artifact by name.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 6, 2019

The sample test passes: https://prow.k8s.io/pr-history/?org=kubeflow&repo=pipelines&pr=1096

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c938247 into kubeflow:master Apr 6, 2019
@Ark-kun Ark-kun deleted the Fixed-Kubeflow-sample-test branch April 6, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 left review comments

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@gaoning777 gaoning777

@hongye-sun hongye-sun

Labels
approved area/testing lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @gaoning777 @k8s-ci-robot @hongye-sun