Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the "Basic - Conditional" sample #1108

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Updated the "Basic - Conditional" sample #1108

merged 2 commits into from
Apr 19, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 9, 2019 •
edited by jlewi
Loading

Modernized the sample pipeline code.
/assign @gaoning777 @hongye-sun
/label area/components

This change is Reviewable

@Ark-kun
Updated the "Basic - Conditional" sample
68cb4e7 
Modernized the sample pipeline code.
@Ark-kun Ark-kun requested review from gaoning777 and hongye-sun April 9, 2019 00:02
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 9, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 9, 2019

The sample tests have passed. https://prow.k8s.io/pr-history/?org=kubeflow&repo=pipelines&pr=1108

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 9, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun Ark-kun force-pushed the Updated-the-"Basic---Condition"-sample branch from 79f5d55 to 71e60f0 Compare April 9, 2019 22:34
hongye-sun
hongye-sun reviewed Apr 19, 2019
View reviewed changes
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 866cc81 into kubeflow:master Apr 19, 2019
@Ark-kun Ark-kun deleted the Updated-the-"Basic---Condition"-sample branch April 19, 2019 19:26
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
feat(sdk): add pipeline_conf.timeout sdk support (kubeflow#1108)
fb32672 
* add pipeline_conf.timeout sdk support

* update unit test script to take kfp config object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun left review comments

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@gaoning777 gaoning777

@hongye-sun hongye-sun

Labels
approved area/samples lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @k8s-ci-robot @hongye-sun @gaoning777