Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Simplified the @component decorator #1166

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 15, 2019

Moved metadata-related code to _metadata.py


This change is Reviewable

Moved metadata-related code to _metadata.
@Ark-kun Ark-kun force-pushed the SDK---Simplified-the-@component-decorator branch from 7d746c2 to 4b272dc Compare April 15, 2019 20:47
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 15, 2019

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 16, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 871a978 into kubeflow:master Apr 16, 2019
@Ark-kun Ark-kun deleted the SDK---Simplified-the-@component-decorator branch April 22, 2019 21:23
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants