Marking the UI-metadata and Metrics artifacts as optional #1260
Conversation
| @@ -193,6 +193,10 @@ def _op_to_template(op: BaseOp): | |||
| for name, path in output_artifact_paths.items() | |||
| ] | |||
|
|
|||
| for output_artifact in output_artifacts: | |||
| if output_artifact['name'] in ['mlpipeline-ui-metadata', 'mlpipeline-metrics']: | |||
| output_artifact['optional'] = True | |||
There was a problem hiding this comment.
Is this field working with current argo image?
There was a problem hiding this comment.
Yes =)
I've discovered that Argo is using slightly broken way to parse YAML, so unknown fields are ignored.
Let's see what the tests say.
There was a problem hiding this comment.
All tests have passed.
There was a problem hiding this comment.
I don't see the sample test passing for the last commit. Actually, it seems that it didn't run for the last commit. Do you know why?
There was a problem hiding this comment.
It did. https://prow.k8s.io/pr-history/?org=kubeflow&repo=pipelines&pr=1260
But the unfinished tests are often shown at the rightmost column under the "Unknown" commit label.
There was a problem hiding this comment.
// When I wrote the comment that the tests have passed, the sample test has already completed the main part and was deleting the cluster. I guess, when you've looked at it, the Prow still has not detected it as finished.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
Marking-the-UI-metadata-and-Metrics-artifacts-as-optional
branch
|
Add a argo PR link: argoproj/argo-workflows#1277 as reference. |
Done. |
Argo has recently fixed a bug argoproj/argo-workflows#1277 . Now the workflows with incorrect missing output artifacts will start failing.
Most of the workflows that have been produced since https://github.com/googleprivate/ml/pull/878 and https://github.com/googleprivate/ml/pull/1311 have been broken. I've tried to prevent this but people did not listen.
Now we have to scramble to fix this messy problem when there are hundreds of broken compiled pipeline packages.
This PR is the first step in the process outlined in #1250 (comment)
This change is