Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new Watson OpenScale components and pipeline #1287

Merged
merged 5 commits into from
May 10, 2019
Merged

Update new Watson OpenScale components and pipeline #1287

merged 5 commits into from
May 10, 2019

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented May 6, 2019 •
edited
Loading

This PR contains the following updates:

  • Generalize object storage to use Minio with HMAC instead of ibm_boto3.
  • Update OpenScale components with the latest OpenScale updates.
  • Update Spark components with some new syntax and outputs.
  • Update Watson Machine Learning deploy to take test payload as optional.
  • Add new OpenScale pipeline to train models with Spark and monitor with OpenScale.

/assign @animeshsingh

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Tomcli. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @Tomcli. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

animeshsingh
animeshsingh suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates - please look at some of the comments above

components/ibm-components/spark/data_preprocess_spark/Dockerfile Outdated Show resolved Hide resolved
components/ibm-components/spark/store_spark_model/Dockerfile Outdated Show resolved Hide resolved
components/ibm-components/spark/store_spark_model/component.yaml Show resolved Hide resolved
components/ibm-components/spark/store_spark_model/src/store_spark_model.py Outdated Show resolved Hide resolved
samples/ibm-samples/openscale/README.md Outdated Show resolved Hide resolved
samples/ibm-samples/openscale/README.md Outdated Show resolved Hide resolved
samples/ibm-samples/openscale/README.md Outdated Show resolved Hide resolved
samples/ibm-samples/openscale/README.md Outdated Show resolved Hide resolved
samples/ibm-samples/openscale/openscale.py Outdated Show resolved Hide resolved
samples/ibm-samples/openscale/openscale.py Outdated Show resolved Hide resolved
@animeshsingh
Copy link
Contributor

/ok-to-test

@animeshsingh
Copy link
Contributor

/lgtm
/approve

@Tomcli
Copy link
Member Author

Tomcli commented May 8, 2019

/retest

1 similar comment
@animeshsingh
Copy link
Contributor

/retest

@Tomcli
Copy link
Member Author

Tomcli commented May 8, 2019

/test all

@cjwagner
Copy link
Member

cjwagner commented May 9, 2019

/hold
Please resolve the GitHub check before trying to merge this PR. This repo is using GitHub checks which are not supported by Tide resulting in a bunch of log spam in addition to wasting our API token rate limit.
ref #930

@cjwagner cjwagner mentioned this pull request May 9, 2019
Closed
@Tomcli
Copy link
Member Author

Tomcli commented May 9, 2019 •
edited
Loading

@animeshsingh @cjwagner Looks like there was a bug where there are 2 GitHub Checks pointing to the same Travis CI job. It is resolved now with a new commit that triggered a new set of GitHub Checks.

@cjwagner
Copy link
Member

cjwagner commented May 9, 2019

/hold cancel

@animeshsingh
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8418b31 into kubeflow:master May 10, 2019
@Tomcli Tomcli mentioned this pull request Jun 5, 2019
Merged
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Merge batcher to model agent (kubeflow#1287)
ab21ad5 
* Refactor batcher

* Fix batcher test

* Inject batcher

* Remove batcher

* Remove batcher injector

* Remove batcher port

* Fix agent injection test
@Tomcli Tomcli deleted the openscale branch February 28, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animeshsingh animeshsingh animeshsingh requested changes

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@animeshsingh animeshsingh

Labels
approved lgtm ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tomcli @k8s-ci-robot @animeshsingh @cjwagner