Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Failing faster in python_op tests #1291

Merged
merged 2 commits into from
May 8, 2019
Merged

SDK - Failing faster in python_op tests #1291

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1101590
SDK - Failing faster in python_op tests
Ark-kun May 3, 2019
1165a6f
Switched to `subprocess.run(full_command, check=True)`
Ark-kun May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/python/tests/components/test_python_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def helper_test_2_in_1_out_component_using_local_call(self, func, op):
task = op(arg1, arg2)

full_command = task.command + task.arguments
process = subprocess.run(full_command)
subprocess.check_call(full_command)
Ark-kun marked this conversation as resolved.
Show resolved Hide resolved

output_path = list(task.file_outputs.values())[0]
actual_str = Path(output_path).read_text()
Expand All @@ -70,7 +70,7 @@ def helper_test_2_in_2_out_component_using_local_call(self, func, op, output_nam

full_command = task.command + task.arguments

process = subprocess.run(full_command)
subprocess.check_call(full_command)

(output_path1, output_path2) = (task.file_outputs[output_names[0]], task.file_outputs[output_names[1]])
actual1_str = Path(output_path1).read_text()
Expand Down