add nuclio components (to build/deploy, delete, invoke functions) #1295

yaronha · 2019-05-07T22:51:47Z

add component to deploy & customize nuclio functions from code/notebook/zip/git, delete functions, and invoke running functions.
see: README.md and https://github.com/nuclio/nuclio-jupyter and https://github.com/nuclio/nuclio

This change is

… and UI, fix broken links (pointed to API vs UI service)

…uclio-components

k8s-ci-robot · 2019-05-07T22:52:02Z

Hi @yaronha. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-05-07T22:52:02Z

Hi @yaronha. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yaronha · 2019-05-07T23:14:22Z

@Ark-kun @jlewi i looked at the CI logs, seems that the errors are not related to the code i pushed, suggestions ?

yaronha · 2019-05-07T23:44:58Z

/assign @Ark-kun

Ark-kun · 2019-05-08T00:11:03Z

components/nuclio/delete/component.yaml

+description: delete a nuclio function.
+inputs:
+  - {name: Name, type: String, description: 'function name'}
+  - {name: Namespace, type: String, description: 'Kubernetes namespace', default: ''}


I do not see the Namespace being passed to the program.

@Ark-kun i will add

@Ark-kun BTW is there a way to pass options w/o values ? e.g. we have -v option for verbose, it doesn't accept a value, just will turn on verbose if the flag exists. if i add it now it will always add -v to the call and i rather not change the executable to accept -v=true

Ark-kun · 2019-05-08T00:12:21Z

components/nuclio/deploy/component.yaml

+  - {name: Env, type: String, description: 'override function env var, Json {key: value, ..}', default: ''}
+  - {name: Mount, type: String, description: 'volume mount, [vol-type:]<vol-url>:<dst-path>', default: ''}
+outputs:
+  - {name: address, type: String, description: 'function endpoint url'}


Maybe rename address to Endpoint (in two places)?

What does a function 'deployment' mean? i believe this is more like 'execute' a function?

@Ark-kun renamed

@animeshsingh deploy takes code + extra files + spec (from code, notebook, zip, git, ..), builds a container, and creates the CRD/deployment for it. a function may be invoked independently e.g. when its doing model serving or ETL from a Kafka/pubsub topic.

see more details/examples on how deploy works in: https://github.com/nuclio/nuclio-jupyter

Ark-kun · 2019-05-08T00:21:55Z

the errors are not related to the code i pushed

I've restarted the tests. It should be fine.

Ark-kun · 2019-05-08T00:27:28Z

components/nuclio/deploy/component.yaml

+      --mount, {inputValue: Mount},
+    ]
+    fileOutputs:
+      address: /tmp/output


JFYI: For future, it's better to have this path passed to the program and not hardcoded in the code.

In
https://github.com/nuclio/nuclio-jupyter/blob/66825220ac659f59d1555ca77568aeecce850e49/nuclio/deploy.py#L69
you should use something like

parser.add_argument('--endpoint-output-file', ...) ... from pathlib import Path Path(args.endpoint_output_file).parent.mkdir(parents=True, exist_ok=True) Path(args.endpoint_output_file).write_text(addr)

and then in component.yaml in the implementation.container.command array you just add --endpoint-output-file, {outputPath: address} and remove the fileOutputs section which should only be used as a workaround for programs with hard-coded paths.

@Ark-kun the address is just an endpoint string (<addr>:<port>), not a file, and it is only written once in the life of that container (container will exit when its done), so instead of writing to arbitrary path or loading to external object, i thought its simpler to hardcode and not burden the user.

i can make it an option

Ark-kun · 2019-05-08T00:52:38Z

/ok-to-test

animeshsingh

Also is there an end to end sample file showing the usage?

animeshsingh · 2019-05-08T01:49:56Z

components/nuclio/README.md

+
+To install Nuclio over Kubernetes follow the [instruction in Github](https://github.com/nuclio/nuclio), 
+or this [interactive tutorial](https://www.katacoda.com/javajon/courses/kubernetes-serverless/nuclio).
+


Are we supposed to install Nuclio on Kube before using these components?

@animeshsingh it can be installed on the same cluster or a different one (defined by the dashboard address)

i plan on adding a page under kubeflow with more detailed install/usage using helm

animeshsingh · 2019-05-08T01:51:50Z

components/nuclio/deploy/component.yaml

+  - {name: Env, type: String, description: 'override function env var, Json {key: value, ..}', default: ''}
+  - {name: Mount, type: String, description: 'volume mount, [vol-type:]<vol-url>:<dst-path>', default: ''}
+outputs:
+  - {name: address, type: String, description: 'function endpoint url'}


What does a function 'deployment' mean? i believe this is more like 'execute' a function?

animeshsingh · 2019-05-08T01:52:53Z

components/nuclio/invoker/component.yaml

+      -l, {inputValue: Log level},
+    ]
+    fileOutputs:
+      output: /tmp/output


So we deploy a 'microservice' , and invoke it?

@animeshsingh see above re deploy, invoke is calling the function (e.g. assume i have a function which does ETL or query data, i invoke it with the query and it process the data), the functions are auto-scaling (from zero or N) and will dynamically allocate resources. e.g. see this function example which reads stock trading data.

note that you dont have to use both, e.g. the pipeline may just deploy an inference function and the invoke will be done directly by an app client via HTTP or stream, e.g. see this function notebook example of TF serving, it can be deployed automatically after the model was generated and serve new requests, the Tag can be used for ingress policies (e.g. A/B testing)

Ark-kun · 2019-05-08T08:33:09Z

/lgtm
/approve

k8s-ci-robot · 2019-05-08T08:33:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/OWNERS~~ [Ark-kun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2019-05-08T08:33:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/OWNERS~~ [Ark-kun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Fix up batcher docs * Move pmml and lightgbm to v1beta1 * Add v1beta1 transformer example * Update feature matrix * Move rollouts * Move custom and transformer examples * Update link

yaronha added 2 commits May 8, 2019 01:40

add support for flexible config (via env var) for the pipline service…

ac651ce

… and UI, fix broken links (pointed to API vs UI service)

Merge branch 'master' of https://github.com/kubeflow/pipelines into n…

2d9bb46

…uclio-components

k8s-ci-robot requested review from animeshsingh, gaoning777 and hongye-sun May 7, 2019 22:51

k8s-ci-robot added size/L needs-ok-to-test labels May 7, 2019

yaronha changed the title ~~add nuclio components (to build/deploy, delete, invoke)~~ add nuclio components (to build/deploy, delete, invoke functions) May 7, 2019

k8s-ci-robot assigned Ark-kun May 7, 2019

Ark-kun reviewed May 8, 2019

View reviewed changes

Ark-kun added the area/components label May 8, 2019

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels May 8, 2019

animeshsingh reviewed May 8, 2019

View reviewed changes

add namespace and change address to endpoint

d153026

k8s-ci-robot added the lgtm label May 8, 2019

k8s-ci-robot added the approved label May 8, 2019

k8s-ci-robot merged commit 442c804 into kubeflow:master May 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add nuclio components (to build/deploy, delete, invoke functions) #1295

add nuclio components (to build/deploy, delete, invoke functions) #1295

yaronha commented May 7, 2019 •

edited by jlewi

Loading

k8s-ci-robot commented May 7, 2019

k8s-ci-robot commented May 7, 2019

yaronha commented May 7, 2019

yaronha commented May 7, 2019

Ark-kun May 8, 2019

yaronha May 8, 2019

yaronha May 8, 2019

Ark-kun May 8, 2019

animeshsingh May 8, 2019

yaronha May 8, 2019

yaronha May 8, 2019

Ark-kun commented May 8, 2019 •

edited

Loading

Ark-kun May 8, 2019 •

edited

Loading

yaronha May 8, 2019

Ark-kun commented May 8, 2019

animeshsingh left a comment

animeshsingh May 8, 2019

yaronha May 8, 2019

yaronha May 8, 2019

animeshsingh May 8, 2019

animeshsingh May 8, 2019

yaronha May 8, 2019

Ark-kun commented May 8, 2019

k8s-ci-robot commented May 8, 2019

k8s-ci-robot commented May 8, 2019


		To install Nuclio over Kubernetes follow the [instruction in Github](https://github.com/nuclio/nuclio),
		or this [interactive tutorial](https://www.katacoda.com/javajon/courses/kubernetes-serverless/nuclio).

add nuclio components (to build/deploy, delete, invoke functions) #1295

add nuclio components (to build/deploy, delete, invoke functions) #1295

Conversation

yaronha commented May 7, 2019 • edited by jlewi Loading

k8s-ci-robot commented May 7, 2019

k8s-ci-robot commented May 7, 2019

yaronha commented May 7, 2019

yaronha commented May 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ark-kun commented May 8, 2019 • edited Loading

Ark-kun May 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ark-kun commented May 8, 2019

animeshsingh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ark-kun commented May 8, 2019

k8s-ci-robot commented May 8, 2019

k8s-ci-robot commented May 8, 2019

yaronha commented May 7, 2019 •

edited by jlewi

Loading

Ark-kun commented May 8, 2019 •

edited

Loading

Ark-kun May 8, 2019 •

edited

Loading