Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing - Clean up the Argo controller that was used to build images #1311

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented May 11, 2019

Currently we have two Argo installation in out test clusters with two controllers. The controllers have different configurations and are conflicting.
This PR cleans up one of the Argo installations.


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 11, 2019

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member

IronPan commented May 13, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e9aa69e into kubeflow:master May 13, 2019
@Ark-kun Ark-kun deleted the Testing---Delete-the-Argo-controller-that-was-used-to-build-images branch May 13, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants