Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kfp sdk] Added examples for ArtifactLocation, ResourceOp, VolumeOp, and Sidecar. #1338

Merged

Conversation

eterna2
Copy link
Contributor

@eterna2 eterna2 commented May 15, 2019

Recent PRs have added quite a few new features to kfp sdk, so I have updated the samples/basic with the following examples:

  • artifact_location.py on how to config artifact location in the pipeline workflow template
  • sidecar.py on how to add sidecars to containerOp in a pipeline

NOTE

As requested by @hongye-sun in #1064, I have added an example for my PR. But I've also added a
few more example for recent PR too.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @eterna2. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @eterna2. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elikatsis
Copy link
Member

elikatsis commented May 15, 2019

These ResourceOp and VolumeOp samples are also under samples/resourceops/, along with other samples on VolumeOps and VolumeSnapshotOps.
Maybe it's better to rearrange those, e.g. create the directories samples/volumes/ and samples/snapshots/ or something like that.

@eterna2
Copy link
Contributor Author

eterna2 commented May 15, 2019

Ah, I didn't realize that. Must have missed them. Cuz the other subfolders looks like extension samples - I assumed all dsl samples are in basic.

I will just remove them and just leave artifact location and sidecar.

@elikatsis
Copy link
Member

I will just remove them and just leave artifact location and sidecar.

Sure, I'll make another PR rearranging them then. Thanks!

@elikatsis
Copy link
Member

/ok-to-test

@eterna2
Copy link
Contributor Author

eterna2 commented May 16, 2019

@Ark-kun updated and remove op-level conf.

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @eterna2.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eterna2
Copy link
Contributor Author

eterna2 commented May 16, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit d821e79 into kubeflow:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants