-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kfp sdk] Added examples for ArtifactLocation, ResourceOp, VolumeOp, and Sidecar. #1338
[kfp sdk] Added examples for ArtifactLocation, ResourceOp, VolumeOp, and Sidecar. #1338
Conversation
Hi @eterna2. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
Hi @eterna2. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These |
Ah, I didn't realize that. Must have missed them. Cuz the other subfolders looks like extension samples - I assumed all dsl samples are in basic. I will just remove them and just leave artifact location and sidecar. |
Sure, I'll make another PR rearranging them then. Thanks! |
/ok-to-test |
@Ark-kun updated and remove op-level conf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @eterna2.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Recent PRs have added quite a few new features to kfp sdk, so I have updated the
samples/basic
with the following examples:artifact_location.py
on how to config artifact location in the pipeline workflow templatesidecar.py
on how to add sidecars to containerOp in a pipelineThis change is