Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP/HTTPS support in FE #1339

Merged
merged 2 commits into from
May 20, 2019
Merged

Add HTTP/HTTPS support in FE #1339

merged 2 commits into from
May 20, 2019

Conversation

eran-nussbaum
Copy link
Contributor

@eran-nussbaum eran-nussbaum commented May 15, 2019 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @eran-nussbaum. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @eran-nussbaum. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rileyjbauer rileyjbauer self-assigned this May 15, 2019
@rileyjbauer
Copy link
Contributor

/ok-to-test

rileyjbauer
rileyjbauer reviewed May 17, 2019
View reviewed changes
Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

frontend/src/lib/WorkflowParser.test.ts Outdated
});
});

it('handles HTTP URL without path', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: HTTPS in test name. Below as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

@rileyjbauer
Copy link
Contributor

Thanks for the work on this!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2da723c into kubeflow:master May 20, 2019
@eran-nussbaum eran-nussbaum deleted the add-http-https-support branch May 20, 2019 07:14
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@abchoo
Determines if predictor is using MMS by checking inference ConfigMap (k…
4af4361 
…ubeflow#1339)

* Revert "Result of openapi-gen"

This reverts commit 4ddf01777e3e408e43ae268a20e9411ad242bc04.

* Result of openapi-gen

* Added multiModelServer field in PredictorConfig

* Added IsMMS function

* Added MultiModelServer flags

* Changed flag from string to bool

* Used inference service config to determine if predictor is MMS

* Changed parameter for IsMMSPredictor: client -> inferenceServiceConfig

* Passed correct parameter to IsMMSPredictor

* Added test for IsMMS

* Added test for IsMMSPredictor

* Comment change for clarity

* Added multiModelServer flag to SKLearn V1

* Turned on mms flag for lightgbm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjbauer rileyjbauer rileyjbauer left review comments

@yebrahim yebrahim Awaiting requested review from yebrahim

Assignees

@rileyjbauer rileyjbauer

Labels
approved area/frontend lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eran-nussbaum @k8s-ci-robot @rileyjbauer