Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents '0' from showing up on RunDetails config tab when pipeline has no parameters #147

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Nov 8, 2018

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Nov 8, 2018

/lgtm

@yebrahim
Copy link
Contributor

yebrahim commented Nov 8, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5746d22 into master Nov 8, 2018
@rileyjbauer rileyjbauer deleted the properly-coerce-array-length branch November 12, 2018 17:50
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Proposed refactor to better encapsulate reconciliation

* Refactored Configuration Reconciler. Tests tbd

* Catching missed files

* Restructured folders

* Pausing before finishing tests

* Working on tests

* Implementing tests

* Finished impl

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants