Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Tests - Removed sys.path manipulations. #151

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 8, 2018

Also fixed compilation path.


This change is Reviewable

Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoning777
Copy link
Contributor

/lgtm
/approve

@IronPan
Copy link
Member

IronPan commented Nov 8, 2018

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 9, 2018

/retest

@Ark-kun Ark-kun force-pushed the avolkov/removed-sys.path-manipulations branch from 1d9e5cc to 6e96b05 Compare November 9, 2018 01:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Also fixed compilation path.
@Ark-kun Ark-kun force-pushed the avolkov/removed-sys.path-manipulations branch from 6e96b05 to 321ca81 Compare November 9, 2018 01:41
@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 9, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 74f2a13 into master Nov 9, 2018
@Ark-kun Ark-kun deleted the avolkov/removed-sys.path-manipulations branch November 9, 2018 21:43
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Use logging.exception to log stacktrace

* update
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants