Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subprocess pip install example in lightweight component example notebook #1817

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Aug 13, 2019

Provide a clear example of subprocess pip install workaround in lightweight python component.


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 13, 2019

/assign @Ark-kun

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 13, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 13, 2019

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 14, 2019

@Ark-kun Shall we merge this?

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 14, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit ced9654 into kubeflow:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants