Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm test to not use coverall #1819

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Update npm test to not use coverall #1819

merged 1 commit into from
Aug 13, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Aug 13, 2019

Consistently getting the following error

/home/travis/build/kubeflow/pipelines/frontend/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 405 <html>
<head><title>405 Not Allowed</title></head>
<body bgcolor="white">
<center><h1>405 Not Allowed</h1></center>
<hr><center>nginx</center>
</body>
</html>
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pipelines-frontend@0.1.0 test:coveralls: `npm run test:coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the pipelines-frontend@0.1.0 test:coveralls script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2019-08-13T06_28_02_279Z-debug.log
The command "npm run test:coveralls" exited with 1.

https://travis-ci.com/kubeflow/pipelines/jobs/224697449


This change is Reviewable

Consistently getting the following error
```
/home/travis/build/kubeflow/pipelines/frontend/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 405 <html>
<head><title>405 Not Allowed</title></head>
<body bgcolor="white">
<center><h1>405 Not Allowed</h1></center>
<hr><center>nginx</center>
</body>
</html>
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pipelines-frontend@0.1.0 test:coveralls: `npm run test:coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the pipelines-frontend@0.1.0 test:coveralls script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2019-08-13T06_28_02_279Z-debug.log
The command "npm run test:coveralls" exited with 1.
```
https://travis-ci.com/kubeflow/pipelines/jobs/224697449
@IronPan
Copy link
Member Author

IronPan commented Aug 13, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Aug 13, 2019

/lgtm

@IronPan IronPan merged commit d710c7a into master Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

@IronPan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 882a22c link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaoning777
Copy link
Contributor

The coverall servers are down. Could you put a TODO such that we add it back? This is good for code quality checking.

@IronPan IronPan deleted the IronPan-patch-7 branch August 16, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants