SDK - Refactoring - Replaced the *Meta classes with the *Spec classes #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the ComponentMeta class with ComponentSpec Replaced the PipelineMeta class with ComponentSpec Replaced the ParameterMeta class with InputSpec and OutputSpec
Ark-kun
force-pushed
the
SDK---Refactoring---Replaced-the--Meta-classes-with-the--Spec-classes
branch
from
dba2022 to
768d270
Compare
Ark-kun
force-pushed
the
SDK---Refactoring---Replaced-the--Meta-classes-with-the--Spec-classes
branch
from
0bef5ad to
02a2463
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> * Feat: Changes on Torchserve repo for KFServing to Kserve migration Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> * update service envelope env variable in serving runtime Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> * fix: move envvar to constants Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> * fix: nil pointer error Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> * fix: torchserve image with kserve envelope Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> * fix: torchserve runtime image Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> * fix: v1 example storage uri - add service_envelope deprecation warining to readme - update torchserve image Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> Co-authored-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring.
Replaced the
ComponentMetaclass withComponentSpecReplaced the
PipelineMetaclass withComponentSpecReplaced the
ParameterMetaclass withInputSpecandOutputSpecThis PR may depend on #1448
This change is