Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK - Stop adding empty descriptions and inputs #1969

Merged
merged 1 commit into from
Sep 11, 2019
Merged

SDK - Stop adding empty descriptions and inputs #1969

merged 1 commit into from
Sep 11, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 27, 2019 •
edited by jlewi
Loading

This change is Reviewable

@ajchili
Copy link
Member

ajchili commented Aug 27, 2019

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

/hold

@gaoning777
Copy link
Contributor

are these descriptions maintained somewhere?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019 •
edited
Loading

are these descriptions maintained somewhere?

I'm not sure I fully understand the question.

@gaoning777
Copy link
Contributor

Are we not keeping the descriptions in the components/pipelines any more?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 28, 2019

Are we not keeping the descriptions in the components/pipelines any more?

We are. I only removed the empty ones.

@numerology
Copy link

It lgtm to remove empty description. May I ask is it still allow to specify description=''?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 30, 2019

Yes, the actual schema does not change.

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 4, 2019

@gaoning777 Can you please take another look?

@gaoning777
Copy link
Contributor

/lgtm

@numerology
Copy link

/hold cancel

@numerology
Copy link

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1962715 into kubeflow:master Sep 11, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Update KServe controller to use Knative 1.0 library (kubeflow#1969)
172933a 
* Knative 1.0 upgrade

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update knative test crds for 1.0

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Set HTTPGet readiness probe for agent container

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Remove agent port hack

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Expose agent container port

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Use minScale/maxScale for compatibility as Knative 1.1 changed to min-scale/max-scale

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update quick install script to use knative 1.0

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Use kserve testing-worker image for go 1.17.3

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinbache kevinbache Awaiting requested review from kevinbache

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@ajchili ajchili Awaiting requested review from ajchili

@numerology numerology Awaiting requested review from numerology

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@kevinbache kevinbache

@gaoning777 gaoning777

@ajchili ajchili

@numerology numerology

Labels
approved area/sdk lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ark-kun @ajchili @k8s-ci-robot @gaoning777 @numerology @kevinbache