Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dataflow sample with the new GCP component #2096

Merged
merged 7 commits into from
Sep 16, 2019
Merged

add dataflow sample with the new GCP component #2096

merged 7 commits into from
Sep 16, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Sep 12, 2019

depending on #2095


This change is Reviewable

@gaoning777
Copy link
Contributor Author

/hold

@gaoning777
Copy link
Contributor Author

/hold cancel

@gaoning777
Copy link
Contributor Author

fixing #2051

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

1 similar comment
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@SinaChavoshi
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 16, 2019
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 52fc2c8 into kubeflow:master Sep 16, 2019
@gaoning777 gaoning777 deleted the add-dataflow-sample branch September 16, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants