Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/CLI: Implement kfp pipeline group #2340

Merged
merged 1 commit into from
Oct 19, 2019
Merged

SDK/CLI: Implement kfp pipeline group #2340

merged 1 commit into from
Oct 19, 2019

Conversation

elikatsis
Copy link
Member

@elikatsis elikatsis commented Oct 9, 2019 •
edited by jlewi
Loading

  • kfp pipeline upload
  • kfp pipeline get
  • kfp pipeline list
  • Use logging [Set logging level to INFO]
  • Catch exceptions raised in command calls and log them as errors
  • Add comment for TODO kfp pipeline delete

Signed-off-by: Ilias Katsakioris elikatsis@arrikto.com

This change is Reviewable

@elikatsis
SDK/CLI: Implement kfp pipeline group
33be69b 
* kfp pipeline upload
* kfp pipeline get
* kfp pipeline list
* Use logging [Set logging level to INFO]
* Catch exceptions raised in command calls and log them as errors
* Add comment for TODO kfp pipeline delete

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
@elikatsis
Copy link
Member Author

/test kubeflow-pipeline-sample-test

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 17, 2019

  • Add comment for TODO kfp pipeline delete

Are you sure your kfp-server-api package is up to date? There was a swagger bug causing those errors and I fixed it by generating the package using a newer version of Swagger Codegen.

@elikatsis
Copy link
Member Author

elikatsis commented Oct 18, 2019 •
edited
Loading

@Ark-kun

Are you sure your kfp-server-api package is up to date? There was a swagger bug causing those errors and I fixed it by generating the package using a newer version of Swagger Codegen.

I'm using kfp-server-api==0.1.18.3.
The availalbe versions are:

... (from versions: 0.1.18.1, 0.1.18.2, 0.1.18.3, 0.1.26)

I'm also seeing these:

  1. pipelines/sdk/python/setup.py

    Line 35 in e9b96de

    'kfp-server-api >= 0.1.18, <= 0.1.25', #Update the upper version whenever a new version of the kfp-server-api package is released. Update the lower version when there is a breaking change in kfp-server-api.

  2. pipelines/sdk/python/requirements.txt

    Line 12 in e9b96de

    kfp-server-api >= 0.1.18, < 0.1.19

So, I guess I'm using the latest accepted version.
Should I use 0.1.26 and fix the requirements [in a separate PR]? Then the requirements should be ==0.1.26, right?

EDIT: Tried it with version 0.1.26 and I'm still getting the error

@elikatsis
Copy link
Member Author

Hmm you probably mean #2418.
I'll hold this until that PR gets merged, and I'll add delete command as well.

/hold

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 18, 2019 •
edited
Loading

Hmm you probably mean #2418.

No that PR is unrelated. The fix I mentioned was in v0.1.18.3: #1685
The problem was that when the API response is empty, Swagger would generate an error.

/hold cancel

@Ark-kun Ark-kun requested a review from jingzhang36 October 18, 2019 22:06
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 18, 2019

Pipeline delete might be deprecated. @jingzhang36 may have details.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 18, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 19, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3b1fc66 into kubeflow:master Oct 19, 2019
@elikatsis elikatsis deleted the cli-kfp-pipeline branch March 9, 2020 14:45
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Check deploymentMode for inference graph (kubeflow#2340)
6b5f3b9 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

Assignees

@hongye-sun hongye-sun

Labels
approved area/cli lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elikatsis @hongye-sun @Ark-kun @k8s-ci-robot