Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix XGBoost sample test flakiness #2410

Closed
wants to merge 2 commits into from

Conversation

numerology
Copy link

@numerology numerology commented Oct 16, 2019

Fix #2405
Temporarily switch back to authoring ContainerOp using existing image. Long term fix requires the ability to set is_exit_handler = True when using component.load_component_from_url/file.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign numerology
You can assign the PR to them by writing /assign @numerology in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 16, 2019

Long term fix requires the ability to set is_exit_handler = True when using component.load_component_from_url/file.

We can also change the dsl.ExitHandler so that it removes the task from the main pipeline.

@numerology
Copy link
Author

Long term fix requires the ability to set is_exit_handler = True when using component.load_component_from_url/file.

We can also change the dsl.ExitHandler so that it removes the task from the main pipeline.

That's actually better. It seems a bit of weird to 'double' specify this property of an op

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 16, 2019

This PR should fix the root of the problem: #2411

@numerology
Copy link
Author

This PR should fix the root of the problem: #2411

Thanks.

@numerology
Copy link
Author

/close

@k8s-ci-robot
Copy link
Contributor

@numerology: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numerology numerology deleted the fix-xgb-test-flakiness branch October 16, 2019 20:29
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* update ray to 2.0.0

Signed-off-by: psj <park12sj@gmail.com>

* update ray to 2.0.0

Signed-off-by: psj <park12sj@gmail.com>

* Revert "update ray to 2.0.0"

This reverts commit c402571f47c77ac3d05e59574ba22e0cbc1ac505.

Signed-off-by: psj <park12sj@gmail.com>

Signed-off-by: psj <park12sj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sample, Component] XGBoost sample test flakiness
3 participants