-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend - Added support for https artifact links #2517
Frontend - Added support for https artifact links #2517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the try! It's a good start. : )
Some nitpickings only.
You need to take a look at Travis failure too. Some formatting warnings there. Follow guide https://github.com/kubeflow/pipelines/tree/master/frontend#code-style for setting up automatic formatting in IDE. Or run a command to format. |
Done. Thanks. |
I've decided to rename GcsLink to ArtifactLink since it's no longer GCS-only. |
@Ark-kun Thanks, this looks great! I didn't add unit tests initially, so let's skip them this time. The changes are simple enough. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Currently the Artifacts list makes artifact URLs clickable only when they are 'gs://'.
This commit adds support for https: links.
This change is