-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Katib experiment launcher #2577
Conversation
- {name: trialTemplate, type: JSON, description: 'Experiment trialTemplate.'} | ||
- {name: Parameter configs, type: JSON, description: 'Experiment Parameter configuration.'} | ||
- {name: Metrics collector, type: JSON, description: 'Experiment metricsCollector.'} | ||
- {name: Experiment timeout minutes, type: Integer, default: 60*24, description: 'Time in minutes to wait for the Experiment to complete.'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
60*24
I'm not sure this will work as it's not an integer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can work, in fact it is 1 day (1440 min)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid confused, change it to 1440
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can work, in fact it is 1 day (1440 min)
I'm curious. Can you tell be why/how this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ark-kun sorry to mislead you, when I replied you, I didn't know what component.yaml is used for, I had thought you were asking me if experimentTimeoutMinites
works.
Now, I had fixed it and test component.yaml
in sample2.py
Thanks
2935b19
to
d14bad1
Compare
/test kubeflow-pipeline-sample-test |
/cc @Tomcli @animeshsingh |
d14bad1
to
a9770dd
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipeline-sample-test |
* make prom metric names consistent Signed-off-by: alexagriffith <agriffith50@bloomberg.net> * updating docs Signed-off-by: alexagriffith <agriffith50@bloomberg.net> Signed-off-by: alexagriffith <agriffith50@bloomberg.net>
Katib experiment launcher for v1alpha3, which is released in kubeflow 0.7.0
This change is