-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing kfp.cli.diagnose_me package to setup.py Fixes #2609 #2610
Adding missing kfp.cli.diagnose_me package to setup.py Fixes #2609 #2610
Conversation
The kfp.cli.diagnose_me package was missing from the setup.py packages list and so wasn't included in the latest release pushed to pypi.org.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @stephenhenderson. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/assign @hongye-sun |
/assign @SinaChavoshi |
Thanks for fixing this! @hongye-sun Looks like we do not run tests for the CLI. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@stephenhenderson: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Nice catch !!! Thank you for finding / fixing this :) |
Signed-off-by: Pan Li <panli889@gmail.com> Signed-off-by: Pan Li <panli889@gmail.com>
The
kfp.cli.diagnose_me
package was missing from the setup.py packages list and so wasn't included in the latest release pushed to pypi.org.This package is required to run the
kfp
CLI - it raises a "Module Not Found" exception if not presentFixes #2609
This change is