Frontend - Add support for Minio artifact URIs #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve You can fix the test failures and it's good to go! |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
I've fixed the tests. Strange that they were passing locally. |
Bobgy
suggested changes
Nov 28, 2019
Ark-kun
force-pushed
the
Frontend---Add-support-for-Minio-artifact-URIs
branch
from
e3f9ecf to
2ab2127
Compare
|
/lgtm Note I fixed the noisy error message in #2672 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Update ModelMesh version to v0.10.0 Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Update install_kserve_mm.sh Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Update ModelMesh charts Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Update helm test Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Keep ns-scoped CRDs Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Wait for port-forward Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Set NAMESPACE_SCOPE=true Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Move ModelMesh ClusterServingRuntimes to clusterservingruntimes.yaml Signed-off-by: Christian Kadner <ckadner@us.ibm.com> Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is