[Sample] CI Sample: helloworld #2833
Conversation
|
Hi @dldaisy. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| _NAMESPACE: kubeflow | ||
| _PIPELINE_ID: [Your kubeflow pipeline id to create a version on. Get it from kfp UI.] | ||
| _GS_BUCKET: [Name of your cloud storage bucket. For example, 'gs://my-bucket'] | ||
| _PIPELINE_ENDPOINT: [Your exposed pipeline endpoint.] |
There was a problem hiding this comment.
maybe give an example here, like: 12345678-dot-us-west1.notebooks.googleusercontent.com
There was a problem hiding this comment.
ok. done with giving a more detailed example.
|
|
||
| # strip gs:// prefix | ||
| bucket_name=$(echo $3 | sed 's/gs:\/\///') | ||
| data='{"name":'\""ci-$1"\"', "code_source_url": "https://github.com/kubeflow/pipelines/tree/'"$1"'", "package_url": {"pipeline_url": "https://storage.googleapis.com/'"$bucket_name"'/'"$1"'/pipeline.zip"}, |
There was a problem hiding this comment.
Sorry maybe a silly question. Should the code_source_url point to the user's repo or KFP's repo?
There was a problem hiding this comment.
code_source_url should points to the user's github repo, as part of source code management. Currently it only acts as a reminder, thus leaving it empty would also work for an example.
|
|
||
| ## Overview | ||
|
|
||
| This sample uses cloudbuild to implement the continuous integration process of a simple pipeline that outputs "hello world" to the console. Once all set up, you can push your code to github repo, then the build process in cloud build will be triggered automatically, then a run will be created in kubeflow pipeline. You can view your pipeline and the run in kubeflow pipelines. |
There was a problem hiding this comment.
Maybe use "Cloud Build" instead of cloud build? Sort of a brand name?
There was a problem hiding this comment.
Same for "Kubeflow Pipelines"
| _GCR_PATH: [Your cloud registry path. For example, gcr.io/myproject] | ||
| _CODE_PATH: /workspace/hello-world | ||
| _NAMESPACE: kubeflow | ||
| _PIPELINE_ID: [Your kubeflow pipeline id to create a version on. Get it from kfp UI.] |
There was a problem hiding this comment.
kfp -> Kubeflow Pipelines
|
/retest |
|
|
||
| substitutions: | ||
| _GCR_PATH: [Your cloud registry path. For example, gcr.io/myproject] | ||
| _CODE_PATH: /workspace/hello-world |
There was a problem hiding this comment.
Could you double check this _CODE_PATH? Should it be something like /workspace/samples/contrib/....
|
/lgtm |
|
@dldaisy is it ready to merge this PR? |
|
@jingzhang36 yes, I think this PR looks good. |
|
/approve |
1 similar comment
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingzhang36, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! @dldaisy |
|
/test kubeflow-pipeline-e2e-test |
|
/retest |
|
/test kubeflow-pipeline-sample-test |
* samples/contrib/versioned-pipeline-ci-samples/helloworld-ci-sample/README.md * hello world sample * more detailed help * use component.yaml instead of ContainerOp * code path
#1 piece for CI samples:
<To make the repo more easily reviewable, pr 2784(#2784) will be broken into smaller prs>
This sample is the simplest helloworld sample for versioned pipeline CI.
This change is