Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for getting all configmaps #2941

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Jan 30, 2020

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 30, 2020

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 30, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun changed the title Adding support for configmap Adding support for getting all configmaps Jan 30, 2020
@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 31, 2020

/retest

2 similar comments
@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 31, 2020

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 31, 2020

/retest

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 9c682a3 into kubeflow:master Jan 31, 2020
@SinaChavoshi SinaChavoshi deleted the diagnose_me branch February 7, 2020 15:54
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Adding support for configmap

* changing Enum to GET_CONFIG_MAPS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants