Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples - Add and change preloaded samples #2944

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 31, 2020

Add the "Data passing in python components" tutorial and the combined "DSL control structures" tutorial.


This change is Reviewable

Add the "Data passing in python components" tutorial.
Combined the "BNasic samples" into the "DSL control structures" tutorial.
@Ark-kun Ark-kun force-pushed the Samples---Change-preloaded-samples branch from 4288801 to 3996e17 Compare January 31, 2020 01:47
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 31, 2020

/retest

@numerology
Copy link

/lgtm
/approve

@numerology
Copy link

/retest

@neuromage
Copy link
Contributor

/approve

@numerology
Copy link

/retest

@IronPan
Copy link
Member

IronPan commented Feb 1, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, neuromage, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology numerology merged commit f729990 into kubeflow:master Feb 1, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Feb 3, 2020

Note, pls take a look at Dockerfile, it pins all urls with blob/master, but not tree/master. Maybe we should do both. I'm not sure what is difference in these

EDIT: nevermind, found you already made the change

Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Samples - Add and change preloaded samples

Add the "Data passing in python components" tutorial.
Combined the "BNasic samples" into the "DSL control structures" tutorial.

* Updated teh Dockerfile to build the tutorials

* Defensive shell programming

* Stop shadowing min and max

* Added missing magic

* Added copyrights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants