[UI] Circular progress for TFX visualization #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Realsen |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Self approved, because already confirmed UX opinion. |
1 similar comment
|
Self approved, because already confirmed UX opinion. |
This was referenced Feb 12, 2020
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Parallelize viewer config fetching requests * Get rid of constructor * Viewer loading progress bar * Adjust circular progress animation UX * Polish UX and clean up code * Update test snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFX visualization usually takes a long time, I implemented a circular progress to reduce the pain of not knowing how long to wait for it.
Demo: https://www.youtube.com/watch?v=avbPeIT7KyI
Changes
Problems fixed
In addition to the main purpose, this also fixed some leaking async behavior.
Fixes #3020
/area frontend
/kind feature
This change is