-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] swf catchup option integration tests #3139
Merged
k8s-ci-robot
merged 15 commits into
kubeflow:master
from
Bobgy:test_swf_catchup_integration
Feb 21, 2020
Merged
[Backend] swf catchup option integration tests #3139
k8s-ci-robot
merged 15 commits into
kubeflow:master
from
Bobgy:test_swf_catchup_integration
Feb 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingzhang36 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Make local testing easier * Move cleanup to test setup stage * Add readme for how to run integration tests * Add warning about data loss * Add warning also in the script * Change flag to isDevMode and cleanup resources if not in dev mode * Pass through arguments in the bash script * Fix unit tests * integration tests for swf NoCatchup option * Also add cron catchup option tests * Restructure test * Adjust format * Fix BUILD.bazel * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR for #3055.
Resolves #3055.
/area backend
/area testing
This change is