Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Fixed handling collection return values #3263

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 11, 2020

Problem: Python components with single unnamed collection outputs are handled incorrectly.

Fixes #3262


This change is Reviewable

@Ark-kun Ark-kun requested a review from numerology March 11, 2020 23:55
@k8s-ci-robot k8s-ci-robot requested a review from hongye-sun March 11, 2020 23:56
@Ark-kun Ark-kun force-pushed the SDK---Components---Fixed-handling-collection-return-values branch from 175e01a to 650e23c Compare March 12, 2020 00:20
@Ark-kun Ark-kun force-pushed the SDK---Components---Fixed-handling-collection-return-values branch from 650e23c to 80dacf6 Compare March 12, 2020 01:25
@Ark-kun Ark-kun force-pushed the SDK---Components---Fixed-handling-collection-return-values branch from ead83b7 to b7e0d72 Compare March 13, 2020 00:37
@numerology
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 119e329 into kubeflow:master Mar 13, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…3263)

* SDK - Components - Fixed handling collection return values

Fixes kubeflow#3262

* Fixed the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python components - Single unnamed collection outputs are handled incorrectly
3 participants