[SDK] Improve host name handling #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
fix #3280 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology, rmgogogo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 17, 2020
Ark-kun
reviewed
Mar 18, 2020
|
|
||
| host = host or '' | ||
| # Preprocess the host endpoint to prevent some common user mistakes. | ||
| host = host.lstrip(r'(https|http)://').rstrip('/') |
There was a problem hiding this comment.
I vaguely remember there were scenarios where this had to be an actual URI with non-empty path.
Something like http://1.2.3.4/something/#pipeline
There was a problem hiding this comment.
Do you mean we have to reserve the prefix http://?
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3280
Automatic stripping http(s) prefix and redundant '/', and throwing warnings when users only provide the backend id.
This change is