added component with tf slim model generator and pipeline adjustments #335
Conversation
|
Hi @dtrawins. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @dtrawins. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
Would it be possible to add unit tests in later PRs? It may become difficult for developers to make changes to this doc otherwise. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| WORKDIR / | ||
| RUN mkdir /bazel && \ | ||
| cd /bazel && \ | ||
| curl -H "User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36" -fSsL -O https://github.com/bazelbuild/bazel/releases/download/$BAZEL_VERSION/bazel-$BAZEL_VERSION-installer-linux-x86_64.sh && \ |
There was a problem hiding this comment.
Why does this need the User Agent header? There should be a comment about this.
|
|
||
| WORKDIR /slim | ||
|
|
||
| RUN git clone --depth 1 https://github.com/tensorflow/models && rm -Rf models/.git && \ |
There was a problem hiding this comment.
Using master is fragile. We should have an ARG and specify some release tag for it.
| @@ -1,7 +1,9 @@ | |||
| #!/usr/bin/python3 | |||
| if return_code: | ||
| exit(1) | ||
|
|
||
| with open('/tmp/output_path.txt', 'w') as f: |
| pb_visual_writer.add_graph(sess.graph) | ||
| print("Visualize the model by running: " | ||
| "tensorboard --logdir={}".format(SAVED_MODEL_DIR)) | ||
| with open('/tmp/saved_model_dir.txt', 'w') as f: |
There was a problem hiding this comment.
/outputs/model_gcs_path/file
| "tensorboard --logdir={}".format(SAVED_MODEL_DIR)) | ||
| with open('/tmp/saved_model_dir.txt', 'w') as f: | ||
| f.write(SAVED_MODEL_DIR) | ||
| with open('/tmp/export_dir.txt', 'w') as f: |
There was a problem hiding this comment.
/outputs/graph_files_gcs_dir/file
New component generating slim models which can be used in combination with other components for demo and testing purposes.
In the PR is included a sample pipeline linking TF slim models generation with OpenVINO model optimization and converting to IR format.
This change is