-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructure local components directory #357
Conversation
/test presubmit-e2e-test |
|
/lgtm |
Agreed, the name 'local' is little confusing. |
/approve |
Local Cloud build test passed. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777, IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777, IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ings (kubeflow#359) * Fix cleanup_ci.py - cleaning of Argo and service account binding * Add logging to make it easier to monitor progress. * Print out stack traces on errors. * cleanup_workflows needs to get GKE credentials. * The project might be different from the project where KF is deployed. Related to kubeflow#358 cleanup ci not cleaning up Argo workflows Related to kubeflow#357 cleanup ci not cleaning up IAM policies. * Fix bug in cleaning up Argo workflows; we should not break out of loop. * Don't exit if delete of Workflow fails; it looks like there might be some race conditions. * Update the docker image to use google-api-python-client library 1.7.0 instead of 1.6.5. It looks like using 1.6.5 gives us an error when getting IAM policy. * Prune the OWNERs file - remove approvers who haven't been very active. * Fix lint.
* adding replace api for kfserving sdk * rollback replace api
This change is