Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure local components directory #357

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 21, 2018

This change is Reviewable

@gaoning777
Copy link
Contributor Author

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 21, 2018

local is fine for now, but let's move to a better name in future. Maybe something like sklearn/confusion_matrix.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 21, 2018

/lgtm

@gaoning777
Copy link
Contributor Author

Agreed, the name 'local' is little confusing.

@gaoning777
Copy link
Contributor Author

/approve

@gaoning777
Copy link
Contributor Author

Local Cloud build test passed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 21, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 21, 2018

/lgtm

@IronPan
Copy link
Member

IronPan commented Nov 26, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c9d8ded into master Nov 26, 2018
@gaoning777 gaoning777 deleted the ngao/local-restructure branch February 8, 2019 18:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…ings (kubeflow#359)

* Fix cleanup_ci.py - cleaning of Argo and service account binding

* Add logging to make it easier to monitor progress.
* Print out stack traces on errors.

* cleanup_workflows needs to get GKE credentials.
  * The project might be different from the project where KF is deployed.

Related to kubeflow#358 cleanup ci not cleaning up Argo workflows

Related to kubeflow#357 cleanup ci not cleaning up IAM policies.

* Fix bug in cleaning up Argo workflows; we should not break out of loop.

* Don't exit if delete of Workflow fails; it looks like there might be
  some race conditions.

* Update the docker image to use google-api-python-client library 1.7.0 instead
  of 1.6.5. It looks like using 1.6.5 gives us an error when getting IAM
  policy.

* Prune the OWNERs file - remove approvers who haven't been very active.

* Fix lint.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* adding replace api for kfserving sdk

* rollback replace api
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants