Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(sdk/client): fix kfp-server-api py client's docstring format #4047

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 22, 2020

Description of your changes:
Fix #3216

Cherry picked template docstring fix in OpenAPITools/openapi-generator#6391 into KFP api client's template, so that generated doc can parse these formats semantically.
The diff c86c59a should be exactly the same as the PR in openapi generator repo.

/assign @Ark-kun

Checklist:

  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@Bobgy Bobgy added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Jun 22, 2020
@kubeflow-bot
Copy link

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 22, 2020

/lgtm
Thank you Yuan for backporting this fix.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title chore(sdk/client): fix generated python client's docstring doc(sdk/client): fix generated python client's docstring Jun 23, 2020
@Bobgy Bobgy changed the title doc(sdk/client): fix generated python client's docstring doc(sdk/client): fix kfp-server-api py client's docstring format Jun 23, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

/retest

1 similar comment
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 23, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

Strange, looks like prow is not healthy

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

/retest

4 similar comments
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 23, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit f456ee9 into kubeflow:master Jun 23, 2020
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 23, 2020

Can you please update the package based on this change?

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 23, 2020

@Ark-kun will do in next rc

@Bobgy Bobgy deleted the fix_py_client_docstring branch June 24, 2020 02:09
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Jul 2, 2020
Bobgy added a commit that referenced this pull request Jul 2, 2020
* Pull templates from upstream 4.3.1

* update templates according to OpenAPITools/openapi-generator/pull/6391

* regenerate python client
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…eflow#4047)

* Pull templates from upstream 4.3.1

* update templates according to OpenAPITools/openapi-generator/pull/6391

* regenerate python client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Documentation about kfp generated api python sdk
4 participants