Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate secret to kaniko #423

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Propagate secret to kaniko #423

merged 2 commits into from
Nov 30, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 30, 2018

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 30, 2018

/assign @gaoning777

Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Nov 30, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 537357a into master Nov 30, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 30, 2018

Later we should completely switch to K8s objects here.

@IronPan IronPan deleted the yangpa/kko branch December 10, 2018 22:26
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* KFP 1.3.0 Rebase

Resolves kubeflow#410

* Fix license headers, markdown ToC, hyperlinks

* Fix merge conflicts in frontend and backend

* Update KFP version references in doc files

* Regenerate "Golden" YAML files any_sequencer, big_data_passing, create_component_from_func

* Regenerate compile report

* Regenerate "golden" YAML files for any_sequencer and parallel_join_with_argo_vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants