Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL - return self for .after() #435

Merged
merged 1 commit into from
Dec 1, 2018
Merged

DSL - return self for .after() #435

merged 1 commit into from
Dec 1, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Dec 1, 2018

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Dec 1, 2018

/assign @qimingj

@IronPan
Copy link
Member Author

IronPan commented Dec 1, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 1, 2018

/lgtm

@qimingj
Copy link
Contributor

qimingj commented Dec 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 9d38f71 into master Dec 1, 2018
@IronPan IronPan deleted the IronPan-patch-11 branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Recreate the NFS share to fix out of space

Fix kubeflow#435

* Remove @zabbasi from the OWNERs file.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* Add deployment scripts

* Small fixes

* Add kustomize image edit during deploy

* Fix issues due to kustomize/kubectl compatibility

* Fix copyright year

* Remove unused script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants