Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): Kustomize manifest for Azure deployments #4567

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

jotaylo
Copy link
Contributor

@jotaylo jotaylo commented Sep 29, 2020

Description of your changes:
Kustomize manifest for KFP deployment using Azure Database for MySQL and MinIO gateway to Azure Blobstore

Checklist:

@kubeflow-bot
Copy link

This change is Reviewable

@google-cla
Copy link

google-cla bot commented Sep 29, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @jotaylo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotaylo jotaylo changed the title feat(deployment): Kustomize template for Azure deployments feat(deployment): Kustomize manifest for Azure deployments Sep 29, 2020
@jotaylo jotaylo mentioned this pull request Sep 29, 2020
@jotaylo
Copy link
Contributor Author

jotaylo commented Sep 29, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 29, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Sep 30, 2020

@Ark-kun let's the continue the discussion here.

We actually accepted AWS manifests from people working for AWS.
#4350

The previous AWS manifests we rejected were maintained by community.

Do you have any concerns with this?

@Bobgy
Copy link
Contributor

Bobgy commented Sep 30, 2020

@jotaylo I want to confirm responsibilities for putting the manifests in kfp repo:

  • Before each release, we'll ask your team to verify your manifests still work for Azure
  • For user issues reported specific to Azure, we'd expect response from your team members
  • In the long term, you should probably maintain your own test infra that continuously ensure it's working so we can reduce some of the manual efforts before release

Do you think that's reasonable?
/cc @dtzar @eedorenko @sudivate

@eedorenko
Copy link
Contributor

Do you think that's reasonable?
Sounds good to me.

/approve

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 30, 2020

We actually accepted AWS manifests from people working for AWS.
#4350

The previous AWS manifests we rejected were maintained by community.

Do you have any concerns with this?

I do not have any concerns. I welcome all contributors. I just wanted our response to be consistent. Glad to see it is consistent.

@eedorenko
Copy link
Contributor

/assign @rmgogogo

@Bobgy
Copy link
Contributor

Bobgy commented Oct 12, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, eedorenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Oct 12, 2020

Sorry for the delay, I was on vacation.

@k8s-ci-robot k8s-ci-robot merged commit 7a5c3c6 into kubeflow:master Oct 12, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants