Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend) Update argo from 2.7.5 to 2.11.6 #4677

Closed
wants to merge 2 commits into from

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Oct 27, 2020

Description of your changes:

Update argo from 2.7.5 to 2.11.6

THis helps to run dsl.ressourceops on k8sapi. See #4645 (comment)

executorimage in configmap is deprecated AFAIK
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juliusvonkohout
To complete the pull request process, please assign bobgy after the PR has been reviewed.
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @juliusvonkohout. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juliusvonkohout juliusvonkohout changed the title WIP Update argo from 2.7.5 to 2.11.6 feat(backend) Update argo from 2.7.5 to 2.11.6 Oct 27, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Oct 29, 2020

Upgrading argo is a pretty hard process, @NikeNano just did once in #4498.
Because we also need to upgrade the argo go package.

I'd suggest working with @NikeNano to see what you can help him with in #4553.

@Bobgy Bobgy closed this Oct 29, 2020
@NikeNano
Copy link
Member

If you like to help out @juliusvonkohout I can create a draft of what I have so far and we can look at it together. Most of the issues and work related to updating argo is related to that several other dependencies also have to be updated. Most concern seems to be related k8s packages that is used in both argo and Kubeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants