-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for the run comparison page #469
Conversation
0a37334
to
a38afb5
Compare
/test presubmit-e2e-test |
50d01c3
to
7aaeb7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* KFP 1.4.0 Rebase Resolves kubeflow#469 * Remove duplicated KFP samples * Resolve api and backend and SDK test conflicts * Upgrade kfp requirements to 1.4.0 * Update testdata regenerate YAML files * Resolve CONTRIBUTING.md * Regenerate KFP samples compile report * Update README.md files for KFP version 1.4.0 * Resolve frontend conflicts * Revert list-wrapped loop arguments * Remove compiler_tests.py.rej
Fixes #382
CollapseButton
is converted to a class so that its react components can be referenced rather than being anonymous.This change is