fix(frontend): Fix logic deciding if a node was cached. Fixes #4814 #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w#4814 The UI was deciding whether a node was cached based on whether it was pointing to some other node's output artifacts. This works for nodes that correspond to pods, but leads to a wrong decision for the rest of the nodes. For example, if the node is a Retry one, it points to another node's outputs because it is that other node that actually produced them. We now apply this logic on pod-type nodes only. Fixes kubeflow#4814 Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
elikatsis
force-pushed
the
fix-ui-cached-decision
branch
from
9937bd4 to
25ede3a
Compare
|
Awesome, your knowledge with argo helps a lot! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, elikatsis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI was deciding whether a node was cached based on whether it was
pointing to some other node's output artifacts.
This works for nodes that correspond to pods, but leads to a wrong
decision for the rest of the nodes. For example, if the node is a Retry
one, it points to another node's outputs because it is that other node
that actually produced them.
We now apply this logic on pod-type nodes only.
Fixes #4814
Signed-off-by: Ilias Katsakioris elikatsis@arrikto.com
/assign @Bobgy
/assign @Ark-kun
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.